Add a callback for dismiss, notifying the caller to perform logic, such as animation.#9
Open
jihchao wants to merge 1 commit intoKrootl:masterfrom
Open
Add a callback for dismiss, notifying the caller to perform logic, such as animation.#9jihchao wants to merge 1 commit intoKrootl:masterfrom
jihchao wants to merge 1 commit intoKrootl:masterfrom
Conversation
Author
klnfreedom
requested changes
Dec 4, 2023
Collaborator
klnfreedom
left a comment
klnfreedom
left a comment
There was a problem hiding this comment.
It is a good idea to add a callback function when a sheet has been closed but change the name of this one.
| required this.position, | ||
| required this.dismissible, | ||
| required this.decorationBuilder, | ||
| this.dismissCallback, |
Collaborator
There was a problem hiding this comment.
Change the name of the function onDismissCallback
| required bool dismissible, | ||
| required int index, | ||
| bool initWithAnimation = true, | ||
| Function? dismissCB, |
Collaborator
There was a problem hiding this comment.
Change the name of the function onDismissCallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a callback for dismiss, notifying the caller to perform logic, such as animation.